lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3615) Make it easier to run Test2BTerms
Date Sat, 03 Dec 2011 02:29:40 GMT


Robert Muir commented on LUCENE-3615:

rather then having "@Weekly" or "@Slow" (or even "@Nightly") annotations, we should just use
an "@Weight(Integer)" annotation indicating how "heavy" a test is

But I'm not sure I agree with this. Most tests have completely different runtime based on
what configurations they get. Sometimes, rarely, we apply totally crazy parameters that make
them go "nuts". Because of this we amortize the cost of checking expensive corner cases (like
termIndexInterval=1, horrible params that cause a lot of merging, etc) across the different
tests. I think this is good, it really finds corner case bugs. So if we had this weight annotation,
i have no clue what we would assign it to anything.

Because you take a test that does a lot of skipping/conjunctions, and if it gets memorycodec
it might be take a terribly long time (since memorycodec doesn't support skipping), but otherwise
it doesnt really care about termsindexinterval. On the other hand you take a test that is
torturing the terms dictionary, and it doesnt care if you give it memorycodec or a shitty
skipinterval, but you give it a crazy termsindexinterval and it spends a lot of time next'ing
thru terms, etc.

Because of this, all of the tests behave in totally different ways that you cant really assign
a weight to, e.g. take a look at the history of test times 
for this test:
> Make it easier to run Test2BTerms
> ---------------------------------
>                 Key: LUCENE-3615
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LUCENE-3615.patch
> Currently, Test2BTerms has an @Ignore annotation which means that the only way to run
it as a test is to edit the file.
> There are a couple of options to fix this:
> # Add a main() so it can be invoked via the command line outside of the test framework
> # Add some new annotations that mark it as slow or weekly or something like that and
have the test target ignore @slow (or whatever) by default, but can also turn it on.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message