lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Khludnev (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2947) DIH caching bug - EntityRunner destroys child entity processor
Date Sun, 04 Dec 2011 20:22:39 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162466#comment-13162466
] 

Mikhail Khludnev commented on SOLR-2947:
----------------------------------------

a few thoughts
* formally DataImporter.initEntity() shouldn't consider config as multithread if the only
single thread is specified
* I'm concerning for overall test coverage for EntityRunners. You see switching to them breaks
the essential feature. Are they tested enough? is it worth to check the actual [coverage|https://builds.apache.org/job/Solr-trunk/1694/clover-report/org/apache/solr/handler/dataimport/DocBuilder.html?line=499#src-499]?
You see there is not tests, where child adds anything into parent. and
* btw, can't we remove DocBuilder.buildDocument() and switch onto EntityRunners to avoid "second
system" issue?
* in TestEphemeralCache I'd like to declare parent as cacheable entity too. Just for check
how it works.

after this, the next fight is true multi-threading.
                
> DIH caching bug - EntityRunner destroys child entity processor
> --------------------------------------------------------------
>
>                 Key: SOLR-2947
>                 URL: https://issues.apache.org/jira/browse/SOLR-2947
>             Project: Solr
>          Issue Type: Sub-task
>          Components: contrib - DataImportHandler
>    Affects Versions: 4.0
>            Reporter: Mikhail Khludnev
>              Labels: noob
>             Fix For: 4.0
>
>         Attachments: dih-cache-destroy-on-threads-fix.patch, dih-cache-threads-enabling-bug.patch
>
>
> My intention is fix multithread import with SQL cache. Here is the 2nd stage. If I enable
DocBuilder.EntityRunner flow even for single thread, it breaks the pretty basic functionality:
parent-child join.
> the reason is [line 473 entityProcessor.destroy();|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DocBuilder.java?revision=1201659&view=markup]
breaks children entityProcessor.
> see attachement comments for more details. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message