lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3621) switch appendingcodec to use appending blocktree
Date Thu, 08 Dec 2011 15:45:40 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165270#comment-13165270
] 

Robert Muir commented on LUCENE-3621:
-------------------------------------

I think instead of making the indexoutput protected in blocktree's writer, we can just pass
the appropriate 
outputs to the writeTrailer methods, and keep it private.

this is more consistent with the read/writeHeader methods.

also i think its bad we write the same codec header to both files... if .tib and .tiv get
switched somehow,
we wouldn't detect it (sorta destroys the point of the codec header).

Ill update the patch.
                
> switch appendingcodec to use appending blocktree
> ------------------------------------------------
>
>                 Key: LUCENE-3621
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3621
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3621.patch
>
>
> currently it still uses block terms + fixed gap index

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message