lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3531) Improve CachingWrapperFilter to optionally also cache acceptDocs, if identical to liveDocs
Date Wed, 14 Dec 2011 13:17:30 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-3531:
----------------------------------

    Attachment: LUCENE-3531-identityFix.patch

New patch, now with WeakIdentityHashMap impl from Apache CXF (excluding its inefficient Collection
views and supporting null keys).

I also changed the CachingWrapperFilter to hold soft references to the DocIdSet, as otherwise
e.g. the Bits==null key will never be purged (as the null key cannot be reclaimed by GC).

We should maybe also change FieldCache to hold soft references to its arrays, as this makes
it more easy to purge them for the GC in low-memory conditions, even if the reader key is
still alive (means field cache can be purged although reader is still alive).
                
> Improve CachingWrapperFilter to optionally also cache acceptDocs, if identical to liveDocs
> ------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3531
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3531
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/search
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-3531-identityFix.patch, LUCENE-3531-identityFix.patch, LUCENE-3531-identityFix.patch,
LUCENE-3531.patch
>
>
> Spinoff from LUCENE-1536: This issue removed the different cache modes completely and
always applies the acceptDocs using BitsFilteredDocIdSet.wrap(), the cache only contains raw
DocIdSet without any deletions/acceptDocs. For IndexReaders that are seldom reopened, this
might not be as performant as it could be. If the acceptDocs==IR.liveDocs, those DocIdSet
could also be cached with liveDocs applied.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message