lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (Updated) (JIRA)" <>
Subject [jira] [Updated] (LUCENE-3645) Remove unnecessary array wrapping when calling varargs methods
Date Wed, 14 Dec 2011 03:50:30 GMT


Steven Rowe updated LUCENE-3645:

    Attachment: LUCENE-3645-branch_3x.patch

bq. Also converted one Arrays.asList(new Integer[0]) to Collections.emptyList()

But these are different right? specifically the first is mutable but the latter is immutable?

Hmm, I hadn't considered that.  Ordinarily I might argue that for a test of sorting an empty
list, immutability is not a problem.

However, LUCENE-2989 switched this exact line *away* from {{Collections.emptyList()}} to what
it is now.

So in this version of the branch_3x patch I've reverted that change and added a comment pointing
to LUCENE-2989.
> Remove unnecessary array wrapping when calling varargs methods
> --------------------------------------------------------------
>                 Key: LUCENE-3645
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.5, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>            Priority: Minor
>         Attachments: LUCENE-3645-branch_3x.patch, LUCENE-3645-branch_3x.patch, LUCENE-3645-trunk.patch
> varargs method callers don't have to wrap args in arrays

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message