lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3665) Make WeightedSpanTermExtractor extensible to handle custom query implemenations
Date Sat, 24 Dec 2011 15:40:31 GMT


Mark Miller commented on LUCENE-3665:

+1 - only looked at the patch, but looks good to me.
> Make WeightedSpanTermExtractor extensible to handle custom query implemenations
> -------------------------------------------------------------------------------
>                 Key: LUCENE-3665
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/highlighter
>    Affects Versions: 3.5
>            Reporter: Simon Willnauer
>            Priority: Minor
>             Fix For: 3.6, 4.0
>         Attachments: LUCENE-3665.patch
> Currently if I have a custom query which subclasses query directly I can't use the QueryScorer
for highlighting since it does explicit instanceof checks. In some cases its is possible to
rewrite the query before passing it to the highlighter to obtain a primitive query. However
I had the usecase where this was not possible ie. the original index was not available on
the machine which highlights the results. To still use the highlighter I had to copy a bunch
of code due to visibility issues in those classes. I think we can make this extensible with
minor effort to allow this usecase without massive code duplication.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message