lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-2929) all postings enums must explicitly declare what they need up-front.
Date Sat, 03 Dec 2011 18:22:40 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless updated LUCENE-2929:
---------------------------------------

    Attachment: LUCENE-2929.patch

New patch; I think it's ready.

Instead of making a new class for every combination of attrs, I think
we should have "class per dimension", ie DocsEnum is used if you only
iterate over docs, no matter which attrs you pull.  So now you pass in
an up front boolean needsFreqs to TermsEnum.docs.

                
> all postings enums must explicitly declare what they need up-front.
> -------------------------------------------------------------------
>
>                 Key: LUCENE-2929
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2929
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2929.patch, LUCENE-2929.patch
>
>
> Currently, the DocsEnum api assumes you *might* consumes freqs at any time.
> Additionally the DocsAndPositionsEnum api assumes you *might* consume a payload at any
time.
> High level things such as queries know what kinds of data they need from the index up-front,
> and the current APIs are limiting to codecs (other than Standard, which has these intertwined).
> So, we either need DocsAndFreqsEnum, DocsPositionsAndPayloadsEnum, or at least booleans
> in the methods that create these to specify whether you want freqs or payloads.
> we did this for freqs in the bulkpostings API, which is good, but these DocsEnum apis
> are also new in 4.0 and there's no reason to introduce non-performant APIs.
> additionally when/if we add payloads to the bulkpostings API, we should make sure we
keep
> the same trend and require you to specify you want payloads or not up-front.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message