lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3623) SegmentReader.getFieldNames ignores FieldOption.DOC_VALUES
Date Wed, 07 Dec 2011 14:36:40 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164426#comment-13164426
] 

Robert Muir commented on LUCENE-3623:
-------------------------------------

{quote}
This means you cannot use PKIndexSplitter and MultiPassIndexSplitter with docValues?
{quote}

Not totally, since this commit most docvalues will work for those cases, just not the SORTED_BYTES
variants.

                
> SegmentReader.getFieldNames ignores FieldOption.DOC_VALUES
> ----------------------------------------------------------
>
>                 Key: LUCENE-3623
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3623
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3623.patch, LUCENE-3623.patch, LUCENE-3623.patch, LUCENE-3623_test.patch
>
>
> we use this getFieldNames api in segmentmerger if we merge something that isn't a SegmentReader
(e.g. FilterIndexReader)
> it looks to me that if you use a FilterIndexReader, call addIndexes(Reader...) the docvalues
will be simply dropped.
> I dont think its enough to just note that the field has docvalues either right? We need
to also set the type 
> correctly in the merged field infos? This would imply that instead of FieldOption.DOCVALUES,
we need to have a 
> FieldOption for each ValueType so that we correctly update the type.
> But looking at FI.update/setDocValues, it doesn't look like we 'type-promote' here anyway?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message