lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3531) Improve CachingWrapperFilter to optionally also cache acceptDocs, if identical to liveDocs
Date Wed, 14 Dec 2011 09:40:31 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169236#comment-13169236
] 

Uwe Schindler commented on LUCENE-3531:
---------------------------------------

This is why most custom implementations of WeakIdentityHashMaps found on the net internally
extend WeakReference to add equals/hashCode to it. It must be one object, otherwise GC may
purge objects.

There is no way around implementing an own WeakIdentityHashMap (not fully implementing the
Map interface, as not needed for caches).
                
> Improve CachingWrapperFilter to optionally also cache acceptDocs, if identical to liveDocs
> ------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3531
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3531
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/search
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-3531-identityFix.patch, LUCENE-3531-identityFix.patch, LUCENE-3531.patch
>
>
> Spinoff from LUCENE-1536: This issue removed the different cache modes completely and
always applies the acceptDocs using BitsFilteredDocIdSet.wrap(), the cache only contains raw
DocIdSet without any deletions/acceptDocs. For IndexReaders that are seldom reopened, this
might not be as performant as it could be. If the acceptDocs==IR.liveDocs, those DocIdSet
could also be cached with liveDocs applied.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message