lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3620) FilterIndexReader does not override all of IndexReader methods
Date Wed, 07 Dec 2011 17:42:45 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164560#comment-13164560
] 

Uwe Schindler commented on LUCENE-3620:
---------------------------------------

In general like reopen, getSequentialSubReaders should default to return null in FilterIndexReader.
If it delegates, the filter has no chance to filter the segments - leading to bugs...
                
> FilterIndexReader does not override all of IndexReader methods
> --------------------------------------------------------------
>
>                 Key: LUCENE-3620
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3620
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3620-trunk.patch, LUCENE-3620.patch, LUCENE-3620.patch, LUCENE-3620.patch
>
>
> FilterIndexReader does not override all of IndexReader methods. We've hit an error in
LUCENE-3573 (and fixed it). So I thought to write a simple test which asserts that FIR overrides
all methods of IR (and we can filter our methods that we don't think that it should override).
The test is very simple (attached), and it currently fails over these methods:
> {code}
> getRefCount
> incRef
> tryIncRef
> decRef
> reopen
> reopen
> reopen
> reopen
> clone
> numDeletedDocs
> document
> setNorm
> setNorm
> termPositions
> deleteDocument
> deleteDocuments
> undeleteAll
> getIndexCommit
> getUniqueTermCount
> getTermInfosIndexDivisor
> {code}
> I didn't yet fix anything in FIR -- if you spot a method that you think we should not
override and delegate, please comment.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message