lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2976) TrieField.isTokenized returns true regardless of precisionStep
Date Fri, 16 Dec 2011 22:26:34 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171269#comment-13171269
] 

Yonik Seeley commented on SOLR-2976:
------------------------------------

IIRC the meaning of isTokenized was taken from lucene long ago:  "True if this field's value
should be analyzed".
Looking at the current uses of isTokenized in Solr, it's been a bit abused and actually may
no longer be needed.

                
> TrieField.isTokenized returns true regardless of precisionStep
> --------------------------------------------------------------
>
>                 Key: SOLR-2976
>                 URL: https://issues.apache.org/jira/browse/SOLR-2976
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.5
>            Reporter: Hoss Man
>
> regardless of the precisionStep used, TrieField.isTokenized is hardcoded to return true
-- so even if a user has something like this in their schema...
> {code}
> <fieldType name="long" class="solr.TrieLongField" precisionStep="0" omitNorms="true"
/>
> <field name="ts" type="long" indexed="true" stored="true" required="true" multiValued="false"
/>
> {code}
> ...any code paths that are driven by isTokenized will think their may be multiple terms
per document when in reality there is at most one.
> we should consider redefining TrieField.isTokenized to be something like...
> {code}
> @Override
> public boolean isTokenized() {
>   return Integer.MAX_VALUE != precisionStep;
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message