lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (Updated) (JIRA)" <>
Subject [jira] [Updated] (SOLR-2950) QueryElevationComponent needlessly looks up document ids
Date Wed, 21 Dec 2011 17:17:30 GMT


Yonik Seeley updated SOLR-2950:

    Attachment: SOLR-2950.patch

OK, just had a chance to view the comparator part of this patch.

Here's a patch that fixes
 - minor check-for-null for fields() and terms() which can return null
 - even though docsEnum returns something, it may be deleted (i.e. need to check for NO_MORE_DOCS)
 - use liveDocs when requesting the docsEnum so we won't use a deleted (overwritten) doc.

The last two issues would both cause us to miss elevated documents if they have been updated
and an old deleted version still exists in the index.
> QueryElevationComponent needlessly looks up document ids
> --------------------------------------------------------
>                 Key: SOLR-2950
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 4.0
>         Attachments: SOLR-2950.patch, SOLR-2950.patch, SOLR-2950.patch, SOLR-2950.patch
> The QueryElevationComponent needlessly instantiates a FieldCache and does look ups in
it for every document.  If we flipped things around a bit and got Lucene internal doc ids
on inform() we could then simply do a much smaller and faster lookup during the sort.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message