Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95BB57878 for ; Tue, 15 Nov 2011 21:36:19 +0000 (UTC) Received: (qmail 48189 invoked by uid 500); 15 Nov 2011 21:36:18 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 48026 invoked by uid 500); 15 Nov 2011 21:36:18 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 48016 invoked by uid 99); 15 Nov 2011 21:36:18 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Nov 2011 21:36:18 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Nov 2011 21:36:12 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id AFA6686E8C for ; Tue, 15 Nov 2011 21:35:51 +0000 (UTC) Date: Tue, 15 Nov 2011 21:35:51 +0000 (UTC) From: "Simon Willnauer (Commented) (JIRA)" To: dev@lucene.apache.org Message-ID: <889385594.32567.1321392951720.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1816508629.26715.1321278651708.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (LUCENE-3572) MultiIndexDocValues pretends it can merge sorted sources MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-3572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150792#comment-13150792 ] Simon Willnauer commented on LUCENE-3572: ----------------------------------------- +1 patch looks good to me > MultiIndexDocValues pretends it can merge sorted sources > -------------------------------------------------------- > > Key: LUCENE-3572 > URL: https://issues.apache.org/jira/browse/LUCENE-3572 > Project: Lucene - Java > Issue Type: Bug > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: 4.0 > > Attachments: LUCENE-3572.patch > > > Nightly build hit this failure: > {noformat} > ant test-core -Dtestcase=TestSort -Dtestmethod=testReverseSort -Dtests.seed=791b126576b0cfab:-48895c7243ecc5d0:743c683d1c9f7768 -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1" > [junit] Testcase: testReverseSort(org.apache.lucene.search.TestSort): Caused an ERROR > [junit] expected:<[CEGIA]> but was:<[ACEGI]> > [junit] at org.apache.lucene.search.TestSort.assertMatches(TestSort.java:1248) > [junit] at org.apache.lucene.search.TestSort.assertMatches(TestSort.java:1216) > [junit] at org.apache.lucene.search.TestSort.testReverseSort(TestSort.java:759) > [junit] at org.apache.lucene.util.LuceneTestCase$3$1.evaluate(LuceneTestCase.java:523) > [junit] at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:149) > [junit] at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:51) > {noformat} > It's happening in the test for reverse-sort of a string field with DocValues, when the test had gotten SlowMultiReaderWrapper. > I committed a fix to the test to avoid testing this case, but we need a better fix to the underlying bug. > MultiIndexDocValues cannot merge sorted sources (I think?), yet somehow it's pretending it can (in the above test, the three subs had BYTES_FIXED_SORTED type, and the TypePromoter happily claims to merge these to BYTES_FIXED_SORTED; I think MultiIndexDocValues should return null for the sorted source in this case? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org