Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 086989741 for ; Sat, 12 Nov 2011 22:38:14 +0000 (UTC) Received: (qmail 70629 invoked by uid 500); 12 Nov 2011 22:38:12 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 70575 invoked by uid 500); 12 Nov 2011 22:38:12 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 70568 invoked by uid 99); 12 Nov 2011 22:38:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Nov 2011 22:38:12 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Nov 2011 22:38:11 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 8E0AA57EFA for ; Sat, 12 Nov 2011 22:37:51 +0000 (UTC) Date: Sat, 12 Nov 2011 22:37:51 +0000 (UTC) From: "Robert Muir (Resolved) (JIRA)" To: dev@lucene.apache.org Message-ID: <1849234466.24539.1321137471583.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <21086974.246861292956804573.JavaMail.jira@thor> Subject: [jira] [Resolved] (LUCENE-2828) SimilarityDelegator broke back-compat for subclasses overriding lengthNorm MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-2828. --------------------------------- Resolution: Won't Fix Assignee: Robert Muir > SimilarityDelegator broke back-compat for subclasses overriding lengthNorm > -------------------------------------------------------------------------- > > Key: LUCENE-2828 > URL: https://issues.apache.org/jira/browse/LUCENE-2828 > Project: Lucene - Java > Issue Type: Bug > Affects Versions: 2.9, 2.9.1, 2.9.2, 2.9.3, 2.9.4, 3.0, 3.0.1, 3.0.2, 3.0.3 > Reporter: Michael McCandless > Assignee: Robert Muir > Fix For: 2.9.5, 3.0.4 > > Attachments: LUCENE-2828.patch > > > In LUCENE-1420, we added Similarity.computeNorm to let the norm computation have access to the raw information (length, boost, etc.). > But this class broke back compat with SimilarityDelegator. We did add computeNorm there, but, it's impl just forwards to the delegee's computeNorm. In the case where a subclass of SimilarityDelegator overrides lengthNorm, that method will no longer be invoked. > Not quite sure how to fix this since, somehow, we have to determine whether the delegee's impl of computeNorm should be favored over the subclasses impl of the "legacy" lengthNorm. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org