lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: IndexReader.doOpenIfChanged javadocs
Date Wed, 02 Nov 2011 13:59:52 GMT
Good point Shai!

Yes, it must return null if there were no changes; else it must return
a new reader (!= this).

Thanks.

Mike McCandless

http://blog.mikemccandless.com

On Wed, Nov 2, 2011 at 9:56 AM, Shai Erera <serera@gmail.com> wrote:
> Hi
>
> While migrating code which overrode IndexReader.reopen to override
> IR.doOpenIfChanged, I ran into an issue that stemmed from the fact that
> apparently doOpenIfChanged needs to return null if the IR wasn't reopened.
> It'd help if it was documented :).
>
> Is that the only contract of the method? I'd like to add some javadocs, so
> please let me know if that's all that needs to be documented.
>
> Shai
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message