lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (Created) (JIRA)" <>
Subject [jira] [Created] (LUCENE-3549) Remove DocumentBuilder interface from facet module
Date Tue, 01 Nov 2011 14:23:32 GMT
Remove DocumentBuilder interface from facet module

                 Key: LUCENE-3549
             Project: Lucene - Java
          Issue Type: Improvement
          Components: modules/facet
            Reporter: Shai Erera
            Assignee: Shai Erera
            Priority: Trivial
             Fix For: 3.5, 4.0

The facet module contains an interface called DocumentBuilder, which contains a single method,
build(Document) (it's a builder API). We use it in my company to standardize how different
modules populate a Document object. I've included it with the facet contribution so that things
will compile with as few code changes as possible.

Now it's time to do some cleanup and I'd like to start with this interface. If people think
that this interface is useful to reside in 'core', then I don't mind moving it there. But
otherwise, let's remove it from the code. It has only one impl in the facet module: CategoryDocumentBuilder,
and we can certainly do without the interface.

More so, it's under o.a.l package which is inappropriate IMO. If it's moved to 'core', it
should be under o.a.l.document.

If people see any problem with that, please speak up. I will do the changes and post a patch
here shortly.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message