lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3572) MultiIndexDocValues pretends it can merge sorted sources
Date Tue, 15 Nov 2011 19:11:52 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless updated LUCENE-3572:
---------------------------------------

    Attachment: LUCENE-3572.patch

OK I mis-diagnosed this!

Indeed the MultiIndexDV.getSource().asSortedSource is returning null,
but then the FieldComparator was swapping in the default source (all
docs have empty byte[]) in this case, which I think is wrong.  Ie, I
think user should see a hard exception if they try to use this
FieldComp on a field whose doc values cannot provide a sorted source.

So I made a small patch w/ that change (attached)... tests pass.  I'll
commit shortly.

                
> MultiIndexDocValues pretends it can merge sorted sources
> --------------------------------------------------------
>
>                 Key: LUCENE-3572
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3572
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-3572.patch
>
>
> Nightly build hit this failure:
> {noformat}
> ant test-core -Dtestcase=TestSort -Dtestmethod=testReverseSort -Dtests.seed=791b126576b0cfab:-48895c7243ecc5d0:743c683d1c9f7768
-Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
>     [junit] Testcase: testReverseSort(org.apache.lucene.search.TestSort):	Caused an ERROR
>     [junit] expected:<[CEGIA]> but was:<[ACEGI]>
>     [junit] 	at org.apache.lucene.search.TestSort.assertMatches(TestSort.java:1248)
>     [junit] 	at org.apache.lucene.search.TestSort.assertMatches(TestSort.java:1216)
>     [junit] 	at org.apache.lucene.search.TestSort.testReverseSort(TestSort.java:759)
>     [junit] 	at org.apache.lucene.util.LuceneTestCase$3$1.evaluate(LuceneTestCase.java:523)
>     [junit] 	at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:149)
>     [junit] 	at org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:51)
> {noformat}
> It's happening in the test for reverse-sort of a string field with DocValues, when the
test had gotten SlowMultiReaderWrapper.
> I committed a fix to the test to avoid testing this case, but we need a better fix to
the underlying bug.
> MultiIndexDocValues cannot merge sorted sources (I think?), yet somehow it's pretending
it can (in the above test, the three subs had BYTES_FIXED_SORTED type, and the TypePromoter
happily claims to merge these to BYTES_FIXED_SORTED; I think MultiIndexDocValues should return
null for the sorted source in this case?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message