lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SOLR-2928) TestIndexingPerformance leaves a write.lock after it finishes
Date Tue, 29 Nov 2011 14:17:40 GMT
TestIndexingPerformance leaves a write.lock after it finishes
-------------------------------------------------------------

                 Key: SOLR-2928
                 URL: https://issues.apache.org/jira/browse/SOLR-2928
             Project: Solr
          Issue Type: Bug
            Reporter: Robert Muir


we had to add a boolean to allow solr tests to explicitly avoid additional checks because
of this, which is bad.

To expose the bug, just do:
{noformat}
Index: solr/test-framework/src/java/org/apache/solr/core/MockDirectoryFactory.java
===================================================================
--- solr/test-framework/src/java/org/apache/solr/core/MockDirectoryFactory.java	(revision
1207870)
+++ solr/test-framework/src/java/org/apache/solr/core/MockDirectoryFactory.java	(working copy)
@@ -31,12 +31,6 @@
 
   @Override
   public Directory create(String path) throws IOException {
-    MockDirectoryWrapper dir = LuceneTestCase.newFSDirectory(new File(path));
-    // Somehow removing unref'd files in Solr tests causes
-    // problems... there's some interaction w/
-    // CachingDirectoryFactory.  Once we track down where Solr
-    // isn't closing an IW, we can re-enable this:
-    dir.setAssertNoUnrefencedFilesOnClose(false);
-    return dir;
+    return LuceneTestCase.newFSDirectory(new File(path));
   }
 }
{noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message