lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3554) AbstractField / Field / NumericField do not override equals and hashcode methods
Date Thu, 03 Nov 2011 18:01:33 GMT


Robert Muir commented on LUCENE-3554:

...but TokenStream (via AttributeSource) already has equals+hashCode methods that aren't just
inherited from Object – are they doing this stream consumption?

Only at that 'state' in time. You would have to walk the tokenstreams in parallel, verifying
equals() along the way, and ensure # of tokens is the same to verify that two tokenstreams
are 'equal'.

if they are, that seems like a bug (TokenStream should probably override AttributeSource to
use "==" and System.identiyHashCode, right?)

No, because it works fine for that stream at that moment in time.

That seems like an orthogonal issue to whether AbstractField/Field/NumericField could have
useful equals/hashCode methods 

Not at all, because fields can be set by tokenstreams, equals/hashcode would be broken if
we did this.

broken != useful.

> AbstractField / Field / NumericField do not override equals and hashcode methods
> --------------------------------------------------------------------------------
>                 Key: LUCENE-3554
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Wish
>          Components: core/index
>            Reporter: Alexandre Dupriez
>            Priority: Minor
>   Original Estimate: 1h 55m
>  Remaining Estimate: 1h 55m
> Field, NumericField and AbstractField implementations of Fieldable do not override equals
and hashcode methods and cannot be compared as such.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message