lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LUCENE-3556) Make DirectoryTaxonomyWriter's indexWriter member private
Date Thu, 03 Nov 2011 06:49:32 GMT
Make DirectoryTaxonomyWriter's indexWriter member private
---------------------------------------------------------

                 Key: LUCENE-3556
                 URL: https://issues.apache.org/jira/browse/LUCENE-3556
             Project: Lucene - Java
          Issue Type: Improvement
          Components: modules/facet
            Reporter: Shai Erera
            Assignee: Shai Erera
            Priority: Trivial
             Fix For: 3.5, 4.0


DirectoryTaxonomyWriter has a protected indexWriter member. As far as I can tell, for two
reasons:

# protected openIndexWriter method which lets you open your own IW (e.g. with a custom IndexWriterConfig).
# protected closeIndexWriter which is a hook for letting you close the IW you opened in the
previous one.

The fixes are trivial IMO:
# Modify the method to return IW, and have the calling code set DTW's indexWriter member
# Eliminate closeIW. DTW already has a protected closeResources() which lets you clean other
resources you've allocated, so I think that's enough.

I'll post a patch shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message