lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (Updated) (JIRA) <>
Subject [jira] [Updated] (SOLR-2280) commitWithin ignored for a delete query
Date Wed, 30 Nov 2011 02:35:41 GMT


Jan Høydahl updated SOLR-2280:

    Attachment: SOLR-2280.patch

Here's a patch for trunk (SOLR-2280.patch). I've also tested and slightly updated the 3x patch,
and named it SOLR-2280-3x.patch.

PS: Juan - we normally create patches using "project" as root, not solr/.

Test coverage is good. One or two more eyes on it and I think it's ready for commit.
> commitWithin ignored for a delete query
> ---------------------------------------
>                 Key: SOLR-2280
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 3.6, 4.0
>         Attachments: SOLR-2280-3x.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch
> The commitWithin option on an UpdateRequest is only honored for requests containing new
documents.  It does not, for example, work with a delete query.  The following doesn't work
as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/>
xml tag as well as <add/>.  Such a change would go in and its would have
some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated
to generate the right XML.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message