lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Khludnev (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SOLR-2933) DIHCacheSupport ignores left side of where="xid=x.id" attribute
Date Wed, 30 Nov 2011 20:21:39 GMT
DIHCacheSupport ignores left side of where="xid=x.id" attribute
---------------------------------------------------------------

                 Key: SOLR-2933
                 URL: https://issues.apache.org/jira/browse/SOLR-2933
             Project: Solr
          Issue Type: Bug
          Components: contrib - DataImportHandler
    Affects Versions: 4.0
            Reporter: Mikhail Khludnev
            Priority: Minor


DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup.
But support old one where="xid=x.id" is broken by [DIHCacheSupport.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DIHCacheSupport.java?view=markup]
- it never put where="" sides into the context, but it revealed by [SortedMapBackedCache.<init>|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SortedMapBackedCache.java?view=markup],
which takes just first column as a primary key. That's why all tests are green.

To reproduce the issue I need just reorder entry at [line 219|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestCachedSqlEntityProcessor.java?revision=1201659&view=markup]
and make desc first and picked up as a primary key. 

To do that I propose to chose concrete map class randomly for all DIH test cases at [createMap()|http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/AbstractDataImportHandlerTestCase.java?revision=1149600&view=markup].


I'm attaching test breaking patch and seed.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message