lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doron Cohen (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3573) TaxonomyReader.refresh() is broken, replace its logic with reopen(), following IR.reopen pattern
Date Tue, 15 Nov 2011 14:05:51 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Doron Cohen updated LUCENE-3573:
--------------------------------

    Attachment: LUCENE-3573.patch

Patch, in principle ready to commit, though I plan to go through it once more.

In this patch:
* new tests moved to TestDirectoryTaxonomyReader
* an exception added: InconsistentTaxonomyException
* when the reader cannot refresh because the taxonomy was recreated since the last time open/refresh,
that exception is thrown and the application should open a fresh taxonomy reader.

Bumped into 3 TODO's while working on this:
* FilterIndexReader does not implement getCommitUserData(). Once this is fixed can resolvethe
TODO in TestIndexClose. I'll open an issue later.
* TR.refresh() should return a boolean indicating anything was changed (issue).
* DTW.rollback() seems wrong to me - it rollback the internal IW, which also closes it, but
then it refreshes its internal TR, seems wrong...
                
> TaxonomyReader.refresh() is broken, replace its logic with reopen(), following IR.reopen
pattern
> ------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3573
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3573
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/facet
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>         Attachments: LUCENE-3573.patch, LUCENE-3573.patch
>
>
> When recreating the taxonomy index, TR's assumption that categories are only added does
not hold anymore.
> As result, calling TR.refresh() will be incorrect at best, but usually throw an AIOOBE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message