lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3590) minimize bytesref to be a ref to a byte[]
Date Thu, 24 Nov 2011 16:33:39 GMT


Robert Muir commented on LUCENE-3590:

Make clone() a shallow copy? I don't think we should support shallow copying at all - it's
normally not going to be what a user really wants. One can still do a shallow copy by directly
setting the members.

No, abusers of the reference API can create a deep copy directly by setting the members. The
onus is on abusers to have these extra lines of code, not for correct users of the API.

Is there even any code in Lucene or Solr that creates a shallow copy?

Yes, and its uglier because of the problems above.

> minimize bytesref to be a ref to a byte[]
> -----------------------------------------
>                 Key: LUCENE-3590
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Priority: Blocker
>         Attachments: LUCENE-3590_copyCtor.patch
> Setting this as blocker for 4.0, as this class is used in every API there.
> Currently this API is a little of a everything, sometimes its like a stringbuffer, it
> does numeric conversions, all kinds of stuff.
> We need this to be a ref to a byte[], nothing else. This other stuff can go somewhere

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message