lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3525) Avoid private nonnested classes
Date Tue, 08 Nov 2011 02:30:51 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146042#comment-13146042
] 

Yonik Seeley commented on LUCENE-3525:
--------------------------------------

This netbeans bug was just reported a few weeks ago - surely it's a transient bug and will
be fixed soon?

We shouldn't blindly change package private classes to static inner clases - first of all,
it sometimes makes no sense... why would NullUpdateLog be scoped within FSUpdateLong?  Second,
it changes the class names (i.e. breaks things Class.forName that are used by solr configuration).

                
> Avoid private nonnested classes
> -------------------------------
>
>                 Key: LUCENE-3525
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3525
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/store
>    Affects Versions: 3.0.3
>            Reporter: Jesse Glick
>            Priority: Minor
>         Attachments: LUCENE-3525.diff
>
>
> https://svn.apache.org/repos/asf/lucene/dev/trunk/lucene/src/java/org/apache/lucene/store/NativeFSLockFactory.java
shows a private top-level class {{NativeFSLock}}. This is a JDK 1.0-ism which should be considered
deprecated. Either use a nested class, or create a separate source file.
> Can produce problems for tools. Cause of: https://netbeans.org/bugzilla/show_bug.cgi?id=204039

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message