lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3548) CharsRef#append broken on trunk & 3.x
Date Tue, 01 Nov 2011 14:11:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141188#comment-13141188
] 

Simon Willnauer commented on LUCENE-3548:
-----------------------------------------

bq. In my opinion the best thing we could do would be to have consistent Bytes/Chars/Ints/LongsRef
apis 
where all the methods have the same semantics!

+1 - I think we should fix the append one in 3.x since we released it and its totally broken
(who did this again - oh me my fault!)
                
> CharsRef#append broken on trunk & 3.x
> -------------------------------------
>
>                 Key: LUCENE-3548
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3548
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/other
>    Affects Versions: 3.4, 3.5, 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3548.patch
>
>
> Current impl. for append on CharsRef is broken - it overrides the actual content rather
than append. its used in many places especially in solr so we might have some broken 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message