lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3590) minimize bytesref to be a ref to a byte[]
Date Fri, 25 Nov 2011 12:53:40 GMT


Robert Muir commented on LUCENE-3590:

Uwe: i totally disagree, I'm sorry.

Instead all these stupid ctors and deep-copying should be removed, and this class should be
simplified to be a simple Ref API.

Then @lucene.internal should be removed from the class, because its totally broken to call
something "internal" but pass it around in every API, e.g. its required to use the terms/postings

Thats why I marked this issue blocker.

> minimize bytesref to be a ref to a byte[]
> -----------------------------------------
>                 Key: LUCENE-3590
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Priority: Blocker
>         Attachments: LUCENE-3590_copyCtor.patch, LUCENE-3590_with_clone.patch
> Setting this as blocker for 4.0, as this class is used in every API there.
> Currently this API is a little of a everything, sometimes its like a stringbuffer, it
> does numeric conversions, all kinds of stuff.
> We need this to be a ref to a byte[], nothing else. This other stuff can go somewhere

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message