lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3533) Nuke SpanFilters and CachingSpanFilter (maybe move to sandbox)
Date Sat, 05 Nov 2011 19:56:51 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-3533:
--------------------------------

    Attachment: LUCENE-3533.patch

Patch, nuking these, but also removing stupid extra seeks from SpanQueries.

The problem is currently:
# seek to every term in every segment to compute IDF/etc
# seek to every term again in every segment to get docsAndPositionsEnum
# (possibly) seek to every term AGAIN in each segment if it doesn't exist, this is when d&penum
returns null, to throw an error message "positions were not indexed". if this third seek returns
null it will return EMPTY_SPANS

with the patch we just do 1 seek
                
> Nuke SpanFilters and CachingSpanFilter (maybe move to sandbox)
> --------------------------------------------------------------
>
>                 Key: LUCENE-3533
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3533
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-3533.patch
>
>
> SpanFilters are inefficient and OOM easily (they don't scale at all: Create large Lists
of Objects for every match, also filtering deleted docs is a pain). Some talks with Grant
on Eurocon and also the fact that caching of them is still broken in 3.x (but fixed on trunk)
- I assume nobody uses them, so let's nuke them. They are also in wrong package, so standard
statement: "Die, SpanFilters, die!"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message