lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2920) Refactor frequent conditional use of DefaultSolrParams into SolrParams.combine(p,d)
Date Wed, 30 Nov 2011 06:11:40 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159850#comment-13159850
] 

David Smiley commented on SOLR-2920:
------------------------------------

Thanks for noticing my issue, Hoss.

"combine" vs "merge" seem similar to me.  "wrap" (if on DefaultSolrParams) or "wrapDefaults"
(if not) sounds clearer to me.

I started this by putting a method in the respective class it came from, but then I noticed
that SolrParams already has some handy static utility methods.  Then it occurred to me that
it would be convenient if the caller didn't need to know about all the classes in this package
-- just SolrParams with some static factory methods.  It's just one class to import too. 
Extending this line of reasoning suggests more refactoring would be in order to create a MapSolrParams.
 What do you think?

RE import statements: It would be nice if there was a standard the project could agree on
so we could just configure our IDEs consistently.  In the mean time, I'll try to reduce import
statement modifications.
                
> Refactor frequent conditional use of DefaultSolrParams into SolrParams.combine(p,d)
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-2920
>                 URL: https://issues.apache.org/jira/browse/SOLR-2920
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: SOLR-2920_SolrParams_combine().patch
>
>
> I had a small bug in use of DefaultSolrParams in my code because I didn't check for non-existent
defaults.  I noticed through the Solr codebase that is code pattern is very common:
> {code:java}
>     if( defaults != null ) {
>       params = new DefaultSolrParams( params, defaults );
>     }
> {code}
> Instead, I refactored this logic into a new SolrParams.combine(p,d) method and made it
so that nobody refers to DefaultSolrParams.  I did similarly for AppendedSolrParams.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message