lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3443) Port 3.x FieldCache.getDocsWithField() to trunk
Date Wed, 09 Nov 2011 00:25:51 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146682#comment-13146682
] 

Yonik Seeley commented on LUCENE-3443:
--------------------------------------

Just because the functionality isn't in 3.x doesn't mean we should feel free to rip it out
of trunk and replace it with something that has less functionality (well, we should be able
to if we think it's for the best, but my point is... it's not.)  IMO, this patch should be
further developed as a patch until the 2-pass problem has been solved as well.  Unless there's
a good reason, we shouldn't be moving backwards.
                
> Port 3.x FieldCache.getDocsWithField() to trunk
> -----------------------------------------------
>
>                 Key: LUCENE-3443
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3443
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3443.patch
>
>
> [Spinoff from LUCENE-3390]
> I think the approach in 3.x for handling un-valued docs, and making it
> possible to specify how such docs are sorted, is better than the
> solution we have in trunk.
> I like that FC has a dedicated method to get the Bits for docs with field
> -- easy for apps to directly use.  And I like that the
> bits have their own entry in the FC.
> One downside is that it's 2 passes to get values and valid bits, but
> I think we can fix this by passing optional bool to FC.getXXX methods
> indicating you want the bits, and the populate the FC entry for the
> missing bits as well.  (We can do that for 3.x and trunk). Then it's
> single pass.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message