lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3552) TaxonomyReader/Writer and their Lucene* implementation
Date Wed, 02 Nov 2011 12:59:33 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142108#comment-13142108
] 

Shai Erera commented on LUCENE-3552:
------------------------------------

Ok, let's keep the interface. It's harmful and I can certainly think of alternate taxonomy
implementations. Perhaps one day someone would want to implement the taxonomy over a serialized
FST or some other data structure ...

So in this case, I'll:
* Keep the interfaces
* Make TaxomomyWriter extend TwoPhaseCommit
* Rename Lucene TaxoWriter/Reader to DirectoryTaxoWriterReader.

Any suggestions about an alternative names to the implementations?
                
> TaxonomyReader/Writer and their Lucene* implementation
> ------------------------------------------------------
>
>                 Key: LUCENE-3552
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3552
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Trivial
>             Fix For: 3.5, 4.0
>
>
> The facet module contains two interfaces TaxonomyWriter and TaxonomyReader, with two
implementations Lucene*. We've never actually implemented two TaxonomyWriters/Readers, so
I'm not sure if these interfaces are useful anymore. Therefore I'd like to propose that we
do either of the following:
> # Remove the interfaces and remove the Lucene part from the implementation classes (to
end up with TW/TR impls). Or,
> # Keep the interfaces, but rename the Lucene* impls to Directory*.
> Whatever we do, I'd like to make the impls/interfaces impl also TwoPhaseCommit.
> Any preferences?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message