lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Cooper (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2864) DataImportHandler has non-deterministic sort order for XML files
Date Wed, 23 Nov 2011 16:37:39 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155952#comment-13155952
] 

Gabriel Cooper commented on SOLR-2864:
--------------------------------------

In re-reading my comment, I realized I wasn't clear on that last sentence. Recursion of course
works, but the recursion *test* didn't actually test recursion due to using the wrong directory
as the base.
                
> DataImportHandler has non-deterministic sort order for XML files
> ----------------------------------------------------------------
>
>                 Key: SOLR-2864
>                 URL: https://issues.apache.org/jira/browse/SOLR-2864
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 3.4
>            Reporter: Gabriel Cooper
>            Priority: Minor
>              Labels: dataimport, patch, xml
>             Fix For: 3.5
>
>         Attachments: lucene-2864.patch, lucene-2864.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> DataImportHandler's FileListEntityProcessor relies on Java's File.list() method to retrieve
a list of files from the configured dataimport directory, but list() does not guarantee a
sort order ^(1)^. This means that if you have two files that update the same record, the results
are non-deterministic. Typically, list() does in fact return them lexigraphically sorted,
but this is not guaranteed ^(2)^.
> An example of how you can get into trouble is to imagine the following:
> xyz.xml -- Created one hour ago. Contains updates to records "Foo" and "Bar".
> abc.xml -- Created one minute ago. Contains updates to records "Bar" and "Baz".
> In this case, the newest file, in abc.xml, would (likely, but not guaranteed) be run
first, updating the "Bar" and "Baz" records. Next, the older file, xyz.xml, would update "Foo"
and overwrite "Bar" with outdated changes.
>  (1) Per http://download.oracle.com/javase/1,5,0/docs/api/java/io/File.html#list%28%29
> "There is no guarantee that the name strings in the resulting array will appear in any
specific order; they are not, in particular, guaranteed to appear in alphabetical order."
>  (2)  Even if it was guaranteed, lexigraphical sorting would give you the following sort
order:
>   1.xml
>   10.xml
>   2.xml
>   ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message