lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2438) Case Insensitive Search for Wildcard Queries
Date Fri, 25 Nov 2011 20:37:40 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157297#comment-13157297
] 

Yonik Seeley commented on SOLR-2438:
------------------------------------

I'm looking at TestFoldingMultitermQuery, and as far as I can tell there only seem to be tests
for positive matches.
For example, there are tests that myfield:A*  match "abacus" on a case insensitive field,
but there are no tests that ensure that it doesn't match on a case sensitive field?

It was especially confusing since there are comments like:
{code}
// test the wildcard queries find only one doc  where the query is uppercased and/or accented.
{code}
That suggest that case sensitivity is also being tested (because of the "only one" phrase),
but that's not the case.  It seems like it should really say
{code}
// test the wildcard queries find the doc even when the query is uppercased and/or accented.
{code}

This patch also introduced a bug that causes regex queries to be lowercased when they shouldn't
be.  I've fixed it in my local copy.

                
> Case Insensitive Search for Wildcard Queries
> --------------------------------------------
>
>                 Key: SOLR-2438
>                 URL: https://issues.apache.org/jira/browse/SOLR-2438
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Peter Sturge
>            Assignee: Erick Erickson
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2438-3x.patch, SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch,
SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch, SOLR-2438.patch, SOLR-2438_3x.patch
>
>
> This patch adds support to allow case-insensitive queries on wildcard searches for configured
TextField field types.
> This patch extends the excellent work done Yonik and Michael in SOLR-219.
> The approach here is different enough (imho) to warrant a separate JIRA issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message