lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-2828) SimilarityDelegator broke back-compat for subclasses overriding lengthNorm
Date Sat, 12 Nov 2011 22:33:51 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149173#comment-13149173
] 

Simon Willnauer commented on LUCENE-2828:
-----------------------------------------

I think we can close this now - I don't see another 2.9 / 3.0 release happening?
                
> SimilarityDelegator broke back-compat for subclasses overriding lengthNorm
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-2828
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2828
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.9, 2.9.1, 2.9.2, 2.9.3, 2.9.4, 3.0, 3.0.1, 3.0.2, 3.0.3
>            Reporter: Michael McCandless
>             Fix For: 2.9.5, 3.0.4
>
>         Attachments: LUCENE-2828.patch
>
>
> In LUCENE-1420, we added Similarity.computeNorm to let the norm computation have access
to the raw information (length, boost, etc.).
> But this class broke back compat with SimilarityDelegator.  We did add computeNorm there,
but, it's impl just forwards to the delegee's computeNorm.  In the case where a subclass of
SimilarityDelegator overrides lengthNorm, that method will no longer be invoked.
> Not quite sure how to fix this since, somehow, we have to determine whether the delegee's
impl of computeNorm should be favored over the subclasses impl of the "legacy" lengthNorm.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message