lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3591) Make BytesRef.copy[Int,Short,Long] package private for DocValues
Date Thu, 24 Nov 2011 17:09:39 GMT


Robert Muir commented on LUCENE-3591:


I think in most cases people that want to do this are happy with ByteArrayDataInput/Output,
its reusable
and supports the DataInput/Output API completely. So most existing consumers that want to
write a long
to a bytearray referred by a BytesRef are using these classes.

But for DV this is a good solution, removes some 'non-ref' APIs/minimizes our API exposure.
> Make BytesRef.copy[Int,Short,Long] package private for DocValues
> ----------------------------------------------------------------
>                 Key: LUCENE-3591
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Sub-task
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>         Attachments: LUCENE-3591.patch
> currently the BytesRef.copy[Int,Short,Long] api is only used by IndexDocValues and it
seems it is pretty unique. I think we should move this into a package private class in o.a.l.i.values
we can still open this up if it is needed by other packages.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message