lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doron Cohen (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3573) TaxonomyReader.refresh() is broken, replace its logic with reopen(), following IR.reopen pattern
Date Wed, 16 Nov 2011 13:00:51 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151177#comment-13151177
] 

Doron Cohen commented on LUCENE-3573:
-------------------------------------

Thanks for the review and comments Shai, and also thanks for taking care of DTW.rollback()
in LUCENE-3579.

I fixed the typos and the == as suggested.

bq. name 'taxoCreateTimeToCommit' just 'taxoCreateTime'

Given your further comment renamed it to 'taxoIndexCreateTime'

bq. Perhaps DirTW.commit() can call commit(null)

I considered this when first coding, as it would have compacted the code. But felt uncomfortable
(still do) relying on a non documented behavior of IW.commit(null).

bq. DirectoryTaxonomyReader.DIR_TAXONOMY_CREATE_TIME_PROP should be in DirTW + renaming to
INDEX_CREATE_TIME

Done.

bq. add a message to InconsistentTaxonomyException

Added.

bq. But why not fix FIR to override getCommitData in this issue?

Done. Now it feels a bit wrong that this will not appear in lucene/CHANGES since this issue
is in lucene/contrib. Guess this is not too bad...?

bq. TR.refresh() should return a boolean indicating anything was changed (issue). I prefer
that we change the method signature once...

Good point. Added a test case in TestDirectoryTaxonomyReader for this.

                
> TaxonomyReader.refresh() is broken, replace its logic with reopen(), following IR.reopen
pattern
> ------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3573
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3573
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/facet
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>         Attachments: LUCENE-3573.patch, LUCENE-3573.patch
>
>
> When recreating the taxonomy index, TR's assumption that categories are only added does
not hold anymore.
> As result, calling TR.refresh() will be incorrect at best, but usually throw an AIOOBE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message