lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doron Cohen (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3573) TaxonomyReader.refresh() is broken, replace its logic with reopen(), following IR.reopen pattern
Date Wed, 16 Nov 2011 13:00:51 GMT


Doron Cohen commented on LUCENE-3573:

Thanks for the review and comments Shai, and also thanks for taking care of DTW.rollback()
in LUCENE-3579.

I fixed the typos and the == as suggested.

bq. name 'taxoCreateTimeToCommit' just 'taxoCreateTime'

Given your further comment renamed it to 'taxoIndexCreateTime'

bq. Perhaps DirTW.commit() can call commit(null)

I considered this when first coding, as it would have compacted the code. But felt uncomfortable
(still do) relying on a non documented behavior of IW.commit(null).

bq. DirectoryTaxonomyReader.DIR_TAXONOMY_CREATE_TIME_PROP should be in DirTW + renaming to


bq. add a message to InconsistentTaxonomyException


bq. But why not fix FIR to override getCommitData in this issue?

Done. Now it feels a bit wrong that this will not appear in lucene/CHANGES since this issue
is in lucene/contrib. Guess this is not too bad...?

bq. TR.refresh() should return a boolean indicating anything was changed (issue). I prefer
that we change the method signature once...

Good point. Added a test case in TestDirectoryTaxonomyReader for this.

> TaxonomyReader.refresh() is broken, replace its logic with reopen(), following IR.reopen
> ------------------------------------------------------------------------------------------------
>                 Key: LUCENE-3573
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/facet
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>         Attachments: LUCENE-3573.patch, LUCENE-3573.patch
> When recreating the taxonomy index, TR's assumption that categories are only added does
not hold anymore.
> As result, calling TR.refresh() will be incorrect at best, but usually throw an AIOOBE.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message