Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E325C7A12 for ; Thu, 20 Oct 2011 18:17:23 +0000 (UTC) Received: (qmail 35616 invoked by uid 500); 20 Oct 2011 18:17:22 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 35533 invoked by uid 500); 20 Oct 2011 18:17:22 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 35526 invoked by uid 99); 20 Oct 2011 18:17:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2011 18:17:22 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [74.125.82.42] (HELO mail-ww0-f42.google.com) (74.125.82.42) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2011 18:17:14 +0000 Received: by wwn22 with SMTP id 22so8465450wwn.5 for ; Thu, 20 Oct 2011 11:16:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.230.101 with SMTP id i79mr3083336weq.65.1319134614305; Thu, 20 Oct 2011 11:16:54 -0700 (PDT) Received: by 10.216.21.79 with HTTP; Thu, 20 Oct 2011 11:16:54 -0700 (PDT) In-Reply-To: References: Date: Thu, 20 Oct 2011 14:16:54 -0400 Message-ID: Subject: Re: FieldType refactoring? From: Michael McCandless To: dev@lucene.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Wed, Oct 19, 2011 at 10:35 PM, Chris Male wrote: > > On Thu, Oct 20, 2011 at 5:23 AM, Adnan Duric wrote: >> >> Hi Chris, >> Thanks for the feedback. If you want to create an issue in JIRA, I'd be >> happy to contribute a patch to convert the FieldType constructor to bit >> flags. How would you want to handle the IndexOptions enum? > > That's a good question. =A0Forcing it to be a compulsory constructor argu= ment > is a little messy, but so is having two constructors to support defaults. > =A0This is the kind of problem that we discussed in LUCENE-2308 as Mike > mentioned. =A0Feel free to open the issue yourself :) and attach a patch = which > deals with it in a way you feel happy with. =A0We can all then review it = and > discuss. I think we could cut over IndexOptions to bits as well? DOCS, FREQS, POSIT= IONS? We'd need checking in FT's ctor to catch wrong pairings, eg you cannot turn ont POSITIONS unless you also turn on FREQS, and at least DOCS must be set if INDEXED is set. Mike --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org