Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Sun, 16 Oct 2011 18:10:11 +0000 (UTC)
From: =?utf-8?Q?Jan_H=C3=B8ydahl_=28Commented=29_=28JIRA=29?=
 <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <674006079.18658.1318788611867.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1305302746.18333.1318772051937.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (SOLR-2842) Re-factor UpdateChain and
 UpdateProcessor interfaces
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/SOLR-2842?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13128=
474#comment-13128474 ]=20

Jan H=C3=B8ydahl commented on SOLR-2842:
-----------------------------------

bq. But the update processor should have access to SolrCore. I don't think =
this is something we want to drop. You do want access to the Request object=
 and the SolrCore, as you have now.
The UpdateRequestProcessorChain now depends on SolrCore for getting config =
from solrconfig.xml, so we'd first need to separate updateChain config from=
 solrconfig, e.g. through SOLR-2841 or similar. Although flexible to have "=
full access" for the Processors, it doesn't necessarily give the best APIs.=
 Most processors will only need access to the input document and request pa=
rams. In addition I think schema access for validating input and a resource=
 loader to load own config from file are good candidates for what to provid=
e to Processors. The resource loader on the client side could resolve resou=
rces locally, or even through the ZK loader.

The remaining 5% of processors which really need SolrCore (such as RunUpdat=
eProcessor) should implement SolrCoreAware, and UpdateChain should statical=
ly check and throw an exception if any of these are attempted loaded in a c=
ontext where SolrCore is null.
               =20
> Re-factor UpdateChain and UpdateProcessor interfaces
> ----------------------------------------------------
>
>                 Key: SOLR-2842
>                 URL: https://issues.apache.org/jira/browse/SOLR-2842
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Jan H=C3=B8ydahl
>
> The UpdateChain's main task is to send SolrInputDocuments through a chain=
 of UpdateRequestProcessors in order to transform them in some way and then=
 (typically) indexing them.
> This generic "pipeline" concept would also be useful on the client side (=
SolrJ), so that we could choose to do parts or all of the processing on the=
 client. The most prominent use case is extracting text (Tika) from large b=
inary documents, residing on local storage on the client(s). Streaming hund=
reds of Mb over to Solr for processing is not efficcient. See SOLR-1526.
> We're already implementing Tika as an UpdateProcessor in SOLR-1763, and w=
hat would be more natural than reusing this - and any other processor - on =
the client side?
> However, for this to be possible, some interfaces need to change slightly=
..

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org