Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Mon, 10 Oct 2011 13:07:30 +0000 (UTC)
From: "Michael McCandless (Commented) (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <668927672.14523.1318252050349.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1077888712.14371.1318249169852.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (LUCENE-3502) Packed ints: move .getArray into
 Reader API
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124064#comment-13124064 ] 

Michael McCandless commented on LUCENE-3502:
--------------------------------------------

OK I'll rename to getArray.

On the .hasArray -- why do we need that?  Can't we just have .getArray and it returns null if there is none?  (None of these classes have a "costly" .getArray impl).  Likewise for DocValues...
                
> Packed ints: move .getArray into Reader API
> -------------------------------------------
>
>                 Key: LUCENE-3502
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3502
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3502.patch
>
>
> This is a simple code cleanup... it's messy that a consumer of
> PackedInts.Reader must check whether the impl is Direct8/16/32/64 in
> order to get an array; it's better to move up the .getArray into the
> Reader interface and then make the DirectN impls package private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org