Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Mon, 24 Oct 2011 15:43:33 +0000 (UTC)
From: "Robert Muir (Commented) (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <637252521.8968.1319471013525.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <585438452.16067.1319129590880.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (SOLR-2848) DirectSolrSpellChecker fails in
 distributed environment
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134160#comment-13134160 ] 

Robert Muir commented on SOLR-2848:
-----------------------------------

{quote}
The problem now we have is we've got a spellchecker that doesn't fully implement a StringDistance all the time.
{quote}

we should fix that hack as i mentioned I think (its just a hack, caused by me, sorry!).

But then we should think about how to make sure that SpellChecker subclasses always work correctly distributed if we aren't going to change the wire format. Rather than instanceof/StringDistance maybe we could add a merge() method that would be more general?
                
> DirectSolrSpellChecker fails in distributed environment
> -------------------------------------------------------
>
>                 Key: SOLR-2848
>                 URL: https://issues.apache.org/jira/browse/SOLR-2848
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud, spellchecker
>    Affects Versions: 4.0
>            Reporter: James Dyer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2848.patch
>
>
> While working on SOLR-2585, it was brought to my attention that DirectSolrSpellChecker has no test coverage involving a distributed environment.  Here I am adding a random element to DistributedSpellCheckComponentTest to alternate between the "IndexBased" and "Direct" spell checkers.  Doing so revealed bugs in using DirectSolrSpellChecker in a distributed environment.  The fixes here roughly mirror those made to the "IndexBased" spell checker with SOLR-2083.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org