lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Updated) (JIRA)" <>
Subject [jira] [Updated] (LUCENE-3473) CheckIndex should verify numUniqueTerms == recomputedNumUniqueTerms
Date Mon, 24 Oct 2011 00:24:32 GMT


Robert Muir updated LUCENE-3473:

    Attachment: LUCENE-3473.patch

More fixes:
* catch(UOE)'s are removed in checkindex because now this stat just returns -1 like other
stats when it isnt available.
* DR.getUniqueTermCount returns -1 like MR now, and I adjusted the test to expect this rather
than the exception.
* Preflex is disabled in the test: only because we currently 'write' preflex indexes actually
as PerFieldCodecWrapper... which is bogus but a larger issue. Still, the preflex method is
being tested for the older indexes when checkIndex runs. once we fix PreFlexRW to be a "real
codec" that writes actual valid 3.x indexes we can remove the assume()

> CheckIndex should verify numUniqueTerms == recomputedNumUniqueTerms
> -------------------------------------------------------------------
>                 Key: LUCENE-3473
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.4, 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3473.patch, LUCENE-3473.patch
> Just glancing at the code it seems to sorta do this check, but only in the hasOrd==true
case maybe (which seems to be testing something else)?
> It would be nice to verify this also for terms dicts that dont support ord.
> we should add explicit checks per-field in 4.x, and for-all-fields in 3.x and preflex

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message