lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Glick (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3525) Avoid private nonnested classes
Date Fri, 21 Oct 2011 19:18:33 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132955#comment-13132955
] 

Jesse Glick commented on LUCENE-3525:
-------------------------------------

The bug in NetBeans was already given in the link above. But this construction is long obsolete
and particularly tricky for tools to support in general (*), so it should be replaced whenever
possible.

(*) Since to find an associated source file you need to inspect a bytecode attribute. For
JDK 1.1+ sources it suffices to just look at the class FQN to determine the source path.
                
> Avoid private nonnested classes
> -------------------------------
>
>                 Key: LUCENE-3525
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3525
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/store
>    Affects Versions: 3.0.3
>            Reporter: Jesse Glick
>            Priority: Minor
>
> https://svn.apache.org/repos/asf/lucene/dev/trunk/lucene/src/java/org/apache/lucene/store/NativeFSLockFactory.java
shows a private top-level class {{NativeFSLock}}. This is a JDK 1.0-ism which should be considered
deprecated. Either use a nested class, or create a separate source file.
> Can produce problems for tools. Cause of: https://netbeans.org/bugzilla/show_bug.cgi?id=204039

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message