lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3539) IndexFormatTooOld/NewExc should try to include fileName + directory when possible
Date Fri, 28 Oct 2011 13:14:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138322#comment-13138322
] 

Robert Muir commented on LUCENE-3539:
-------------------------------------

you might be able to work me down to a partial path rather than a full path...

like if IndexInput takes String name in its ctor (the same one passed to Directory.openInput
*NOT* the full path, keeps String as a private variable), and implements toString itself.

then we wouldnt have to track additional variables in each indexinput impl, only change openinput
and the ctors to pass this information.

But i'm still not sure how useful this is. 

It really seems like an implementation detail that we check the stored fields to determine
if an indexformat is too old. who cares what the file name is?

                
> IndexFormatTooOld/NewExc should try to include fileName + directory when possible
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-3539
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3539
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3539.patch
>
>
> (Spinoff from http://markmail.org/thread/t6s7nn3ve765nojc )
> When we throw a too old/new exc we should try to include the full path to the offending
file, if possible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message