lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2848) DirectSolrSpellChecker fails in distributed environment
Date Sat, 22 Oct 2011 12:18:32 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133350#comment-13133350
] 

Robert Muir commented on SOLR-2848:
-----------------------------------

Thanks for bringing this up James, a few questions:
* Can we instead fold these changes into the base spellchecking class or somewhere else in
Solr? I don't think a spellchecking implementation should have to deal with this stuff, this
is a plugin API and it should only have to implement spellcheck.
* Is there a way we can remove the instanceof checks in SpellCheckComponent completely? I
think seeing these is a sign there is a serious problem in the spellchecking APIs.
* what is the problem with the internal levenshtein implementation? I'm not sure we should
silently change this here, i don't understand why we should use the slower one if the user
asked for 'internal'.
                
> DirectSolrSpellChecker fails in distributed environment
> -------------------------------------------------------
>
>                 Key: SOLR-2848
>                 URL: https://issues.apache.org/jira/browse/SOLR-2848
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud, spellchecker
>    Affects Versions: 4.0
>            Reporter: James Dyer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2848.patch
>
>
> While working on SOLR-2585, it was brought to my attention that DirectSolrSpellChecker
has no test coverage involving a distributed environment.  Here I am adding a random element
to DistributedSpellCheckComponentTest to alternate between the "IndexBased" and "Direct" spell
checkers.  Doing so revealed bugs in using DirectSolrSpellChecker in a distributed environment.
 The fixes here roughly mirror those made to the "IndexBased" spell checker with SOLR-2083.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message