lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Lavelle (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3246) Invert IR.getDelDocs -> IR.getLiveDocs
Date Wed, 19 Oct 2011 20:11:10 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130945#comment-13130945
] 

Sean Lavelle commented on LUCENE-3246:
--------------------------------------

I think the javadoc comments for TermsEnum.docs are now incorrect due to this commit. It says
"@param liveDocs set bits are documents that should not be returned", which looks backwards.
(maybe other places are wrong too; I haven't checked)

                
> Invert IR.getDelDocs -> IR.getLiveDocs
> --------------------------------------
>
>                 Key: LUCENE-3246
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3246
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-3246-IndexSplitters.patch, LUCENE-3246.patch, LUCENE-3246.patch
>
>
> Spinoff from LUCENE-1536, where we need to fix the low level filtering
> we do for deleted docs to "match" Filters (ie, a set bit means the doc
> is accepted) so that filters can be pushed all the way down to the
> enums when possible/appropriate.
> This change also inverts the meaning first arg to
> TermsEnum.docs/AndPositions (renames from skipDocs to liveDocs).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message