lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3488) Factor out SearcherManager from NRTManager
Date Wed, 05 Oct 2011 18:28:30 GMT


Yonik Seeley commented on LUCENE-3488:

bq. if we take this as a basis we should have never started with flex, DWPT etc.

You mean those didn't make sense to start off with? ;-)

Anyway, I take exception to the characterization of this part of Solr's code as "atrocious",
and really don't understand where it comes from or what the specific complaints are.  But
as always, patches welcome.
> Factor out SearcherManager from NRTManager
> ------------------------------------------
>                 Key: LUCENE-3488
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.5, 4.0
>            Reporter: Simon Willnauer
>             Fix For: 3.5, 4.0
>         Attachments: LUCENE-3488.patch
> Currently we have NRTManager and SearcherManager while NRTManager contains a big piece
of the code that is already in SearcherManager. Users are kind of forced to use NRTManager
if they want to have SearcherManager goodness with NRT. The integration into NRTManager also
forces you to maintain two instances even if you know you always want deletes. To me NRTManager
tries to do more than necessary and mixes lots of responsibilities ie. handling searchers
and handling indexing generations. NRTManager should use a SearcherManager by aggregation
rather than duplicate a lot of logic. SearcherManager should have a NRT and Directory based
implementation users can simply choose from.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message