lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3512) Expose fields in FieldPhraseList and WeightedPhraseInfo with public getters
Date Wed, 12 Oct 2011 17:49:11 GMT


Simon Willnauer commented on LUCENE-3512:

that looks reasonable to me. some comments:

 * can we rename public int getSeqnum() to something more useful? it seems getPhraseNumber
is better though?
 * I wonder if we really need to expose the implementation rather than the interface in public
LinkedList<WeightedPhraseInfo> getPhraseList()? This should return List<WeightedPhraseInfo>
 * would you mind adding one or two doc strings to those getters? 
 * while you are on it feel free to add more reasonable names etc. to that class

> Expose fields in FieldPhraseList and WeightedPhraseInfo with public getters
> ---------------------------------------------------------------------------
>                 Key: LUCENE-3512
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/highlighter
>    Affects Versions: 3.4
>            Reporter: Kelsey Francis
>            Priority: Minor
>         Attachments: LUCENE-3512.patch
> Currently, to write a custom {{FragListBuilder}} implementation or custom highlighter,
it probably will have to be placed in the {{}} package
so that it has access to the fields in {{FieldPhraseList}} and its inner class {{WeightedPhraseInfo}}.
It seems that in recent releases, getters were added for fields in many other classes in {{vectorhighlight}},
and I think it makes sense to add them for fields in {{FieldPhraseList}} as well to support
such custom implementations.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message