lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3517) Fix pulsingcodec to reuse its enums
Date Fri, 14 Oct 2011 17:58:12 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-3517:
--------------------------------

    Attachment: LUCENE-3517.patch

patch with a nested case: Pulsing1(Pulsing2(Standard)).

See the comments in the test, we actually create 4 enums when we could really reuse more.
But its 'correct' and I think this is good enough for this crazy case.
                
> Fix pulsingcodec to reuse its enums
> -----------------------------------
>
>                 Key: LUCENE-3517
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3517
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3517.patch, LUCENE-3517.patch, LUCENE-3517.patch, LUCENE-3517.patch
>
>
> PulsingCodec currently doesnt always reuse its enums, which could lead to behavior like
LUCENE-3515.
> The problem is sometimes it returns the 'wrapped' enum, but other times it returns its
'pulsingenum' depending upon
> whether terms are pulsed...
> we can use the fact that these enums allow attributes to keep the reuse information for
both so it can reuse when stepping through terms.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message