lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3473) CheckIndex should verify numUniqueTerms == recomputedNumUniqueTerms
Date Mon, 24 Oct 2011 17:11:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134248#comment-13134248
] 

Robert Muir commented on LUCENE-3473:
-------------------------------------

Uwe yes: i was actually adding this test only for debugging... I'll remove it (it does not
give us any additional test coverage)
                
> CheckIndex should verify numUniqueTerms == recomputedNumUniqueTerms
> -------------------------------------------------------------------
>
>                 Key: LUCENE-3473
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3473
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.4, 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3473.patch, LUCENE-3473.patch, LUCENE-3473.patch
>
>
> Just glancing at the code it seems to sorta do this check, but only in the hasOrd==true
case maybe (which seems to be testing something else)?
> It would be nice to verify this also for terms dicts that dont support ord.
> we should add explicit checks per-field in 4.x, and for-all-fields in 3.x and preflex

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message