lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3534) Backport FilteredQuery/IndexSearcher changes to 3.x: Remove filter logic from IndexSearcher and delegate to FilteredQuery
Date Tue, 25 Oct 2011 15:00:37 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135128#comment-13135128
] 

Uwe Schindler commented on LUCENE-3534:
---------------------------------------

My problem is that this backport is almost impossible: Searchable and Searcher abstract class
prevent this from being done.

We have several choices:
- we can heavily break backwards and maybe nuke Searcher and Searchable earlier
- we keep API intact, only call FilteredQuery.weight() from inside IndexSaercher instead of
duplicating code
- close issue as won't fix

Any comments?
                
> Backport FilteredQuery/IndexSearcher changes to 3.x: Remove filter logic from IndexSearcher
and delegate to FilteredQuery
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3534
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3534
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>
> Spinoff from LUCENE-1536: We simplified the code in IndexSearcher to no longer do the
filtering there, instead wrap all Query with FilteredQuery, if a non-null filter is given.
The conjunction code would then only exist in FilteredQuery which makes it easier to maintain.
Currently both implementations differ in 3.x, in trunk we used the more optimized IndexSearcher
variant with addition of a simplified in-order conjunction code.
> This issue will backport those changes (without random access bits).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message